Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add tracing without performance to Node http integration #8450

Merged
merged 2 commits into from
Jul 11, 2023
Merged

feat(node): Add tracing without performance to Node http integration #8450

merged 2 commits into from
Jul 11, 2023

Conversation

AbhiPrasad
Copy link
Member

ref #8352

Updates the Node HTTP integration to always attach sentry-trace headers to outgoing requests.

This can be controlled with the top level tracePropagationOptions option.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team July 4, 2023 16:10
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 5, 2023
Closed
@AbhiPrasad AbhiPrasad added this to the Tracing without Performance milestone Jul 5, 2023
@AbhiPrasad AbhiPrasad self-assigned this Jul 5, 2023
@AbhiPrasad
Copy link
Member Author

All these test failures are v confusing as well 😢

@AbhiPrasad
Copy link
Member Author

Alright I'm forcing sampling decisions for the integration tests, hopefully that helps with the problems.

The biggest problem with our Remix and Nextjs integration tests is that the Sentry instances bleeds into the tests for some reason - we need true encapsulation like our e2e tests I think.

Also both the nextjs and remix tests are super tough to debug - the DX needs to be improved here.

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Jul 5, 2023 •
edited
Loading

~alright so looks like we're good for nextjs (other than flakes), only remix is being weird 🤔 ~

nvm 😭

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.1 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.14 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.5 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.82 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad marked this pull request as draft July 5, 2023 20:14
@AbhiPrasad
Copy link
Member Author

One day tests will pass and it will be glorious...

@AbhiPrasad AbhiPrasad force-pushed the abhi-twp-node-http branch 2 times, most recently from af3dd18 to 2950ca6 Compare July 10, 2023 16:08
@AbhiPrasad AbhiPrasad marked this pull request as ready for review July 10, 2023 18:14
@AbhiPrasad
Copy link
Member Author

e2e tests should be taken care of by #8486

mydea
mydea reviewed Jul 11, 2023
View reviewed changes
packages/node/src/integrations/http.ts
@@ -96,13 +108,20 @@ export class Http implements Integration {
return;
}

// TODO (v8): `tracePropagationTargets` and `shouldCreateSpanForRequest` will be removed from clientOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Should we keep this v8 comment around?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so, it doesn't apply anymore and deprecation should take care of the tracePropagationTargets option.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 11, 2023 15:09
Lms24
Lms24 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor around header normalization and setting the headers!

@AbhiPrasad AbhiPrasad merged commit 5caec05 into develop Jul 11, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-twp-node-http branch July 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
Tracing without Performance
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @mydea @Lms24