-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Refactor E2E test running #8497
Conversation
size-limit report 📦
|
a1ff4e0
to
60a6618
Compare
2041d6a
to
4ec760a
Compare
eed11a1
to
338a5ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Love the simplifications and that we now immediately see which test failed!
packages/e2e-tests/test-applications/create-next-app/tests/behaviour-client.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we don't run in parallel on the same machine anymore we could switch back to yarn. But LGTM
FYI I also updated the canary issue creation to include which test failed, so we get distinct issues per E2E test failure. |
This refactors how we run E2E tests, to a more simple approach.
CI
In CI, we now have a matrix job for the E2E tests, where each test runs in parallel & isolation.
Example: https://github.com/getsentry/sentry-javascript/actions/runs/5541658717
Canary
For the canary tests, we also have to specify each canary job we want to run in a matrix.
Example: https://github.com/getsentry/sentry-javascript/actions/runs/5541662790
Locally
You can either run all tests:
Or only run a single test suite: