-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): Test Remix and NextJS SDKs on Node 20. #8577
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
382d916
test(remix): Test Remix SDK on Node 20.
onurtemizkan 1b8f3a4
Increase timeout to 10 seconds.
onurtemizkan f7f73a5
Resolve after server is closed.
onurtemizkan ec6b8b1
Increase `statusText` test timeouts.
onurtemizkan 1eca3e2
Abort pending nock requests to prevent flakes.
onurtemizkan 2698626
Unref test server on close.
onurtemizkan 26c31bd
Revert increased timeouts.
onurtemizkan 88e7ed2
Run server-side tests in band.
onurtemizkan c1de6fc
Emit 'close' event from server.
onurtemizkan 91ea120
Use `http-terminator` for complete server termination.
onurtemizkan bc9e210
Use `portfinder` as late as possible.
onurtemizkan b453468
Update `http-terminator` usage.
onurtemizkan 470c7cb
Remove `portfinder`.
onurtemizkan 6ae5375
Cleanup
onurtemizkan 5f6316b
Remove `portfinder` from NextJS tests.
onurtemizkan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6104,7 +6104,7 @@ [email protected]: | |
require-from-string "^2.0.2" | ||
uri-js "^4.2.2" | ||
|
||
ajv@^6.1.0, ajv@^6.10.0, ajv@^6.10.2, ajv@^6.12.3, ajv@^6.12.4, ajv@^6.12.5: | ||
ajv@^6.1.0, ajv@^6.10.0, ajv@^6.10.2, ajv@^6.11.0, ajv@^6.12.3, ajv@^6.12.4, ajv@^6.12.5: | ||
version "6.12.6" | ||
resolved "https://registry.yarnpkg.com/ajv/-/ajv-6.12.6.tgz#baf5a62e802b07d977034586f8c3baf5adf26df4" | ||
integrity sha512-j3fVLgvTo527anyYyJOGTYJbG+vnnQYvE0m5mmkc1TK+nxAppkCLMIL0aZ4dblVCNoGShhm+kzE4ZUykBoMg4g== | ||
|
@@ -7853,6 +7853,11 @@ boolbase@^1.0.0, boolbase@~1.0.0: | |
resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e" | ||
integrity sha1-aN/1++YMUes3cl6p4+0xDcwed24= | ||
|
||
boolean@^3.1.4: | ||
version "3.2.0" | ||
resolved "https://registry.yarnpkg.com/boolean/-/boolean-3.2.0.tgz#9e5294af4e98314494cbb17979fa54ca159f116b" | ||
integrity sha512-d0II/GO9uf9lfUHH2BQsjxzRJZBdsjgsBiW4BvhWk/3qoKwQFjIDVN19PfX8F2D/r9PCMTtLWjYVCFrpeYUzsw== | ||
|
||
bower-config@^1.4.3: | ||
version "1.4.3" | ||
resolved "https://registry.yarnpkg.com/bower-config/-/bower-config-1.4.3.tgz#3454fecdc5f08e7aa9cc6d556e492be0669689ae" | ||
|
@@ -10798,6 +10803,11 @@ del@^4.1.1: | |
pify "^4.0.1" | ||
rimraf "^2.6.3" | ||
|
||
delay@^5.0.0: | ||
version "5.0.0" | ||
resolved "https://registry.yarnpkg.com/delay/-/delay-5.0.0.tgz#137045ef1b96e5071060dd5be60bf9334436bd1d" | ||
integrity sha512-ReEBKkIfe4ya47wlPYf/gu5ib6yUG0/Aez0JQZQz94kiWtRQvZIQbTiehsnwHvLSWJnQdhVeqYue7Id1dKr0qw== | ||
|
||
delayed-stream@~1.0.0: | ||
version "1.0.0" | ||
resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619" | ||
|
@@ -13129,6 +13139,16 @@ [email protected], [email protected], fast-json-stab | |
resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.1.0.tgz#874bf69c6f404c2b5d99c481341399fd55892633" | ||
integrity sha512-lhd/wF+Lk98HZoTCtlVraHtfh5XYijIjalXck7saUtuanSDyLMxnHhSXEDJqHxD7msR8D0uCmqlkwjCV8xvwHw== | ||
|
||
fast-json-stringify@^2.7.10: | ||
version "2.7.13" | ||
resolved "https://registry.yarnpkg.com/fast-json-stringify/-/fast-json-stringify-2.7.13.tgz#277aa86c2acba4d9851bd6108ed657aa327ed8c0" | ||
integrity sha512-ar+hQ4+OIurUGjSJD1anvYSDcUflywhKjfxnsW4TBTD7+u0tJufv6DKRWoQk3vI6YBOWMoz0TQtfbe7dxbQmvA== | ||
dependencies: | ||
ajv "^6.11.0" | ||
deepmerge "^4.2.2" | ||
rfdc "^1.2.0" | ||
string-similarity "^4.0.1" | ||
|
||
fast-levenshtein@^2.0.6, fast-levenshtein@~2.0.6: | ||
version "2.0.6" | ||
resolved "https://registry.yarnpkg.com/fast-levenshtein/-/fast-levenshtein-2.0.6.tgz#3d8a5c66883a16a30ca8643e851f19baa7797917" | ||
|
@@ -13141,6 +13161,13 @@ fast-ordered-set@^1.0.0: | |
dependencies: | ||
blank-object "^1.0.1" | ||
|
||
fast-printf@^1.6.9: | ||
version "1.6.9" | ||
resolved "https://registry.yarnpkg.com/fast-printf/-/fast-printf-1.6.9.tgz#212f56570d2dc8ccdd057ee93d50dd414d07d676" | ||
integrity sha512-FChq8hbz65WMj4rstcQsFB0O7Cy++nmbNfLYnD9cYv2cRn8EG6k/MGn9kO/tjO66t09DLDugj3yL+V2o6Qftrg== | ||
dependencies: | ||
boolean "^3.1.4" | ||
|
||
fast-sourcemap-concat@^2.1.0: | ||
version "2.1.0" | ||
resolved "https://registry.yarnpkg.com/fast-sourcemap-concat/-/fast-sourcemap-concat-2.1.0.tgz#12dd36bfc38c804093e4bd1de61dd6216f574211" | ||
|
@@ -14323,6 +14350,13 @@ globals@^9.18.0: | |
resolved "https://registry.yarnpkg.com/globals/-/globals-9.18.0.tgz#aa3896b3e69b487f17e31ed2143d69a8e30c2d8a" | ||
integrity sha512-S0nG3CLEQiY/ILxqtztTWH/3iRRdyBLw6KMDxnKMchrtbj2OFmehVh0WUCfW3DUrIgx/qFrJPICrq4Z4sTR9UQ== | ||
|
||
globalthis@^1.0.2: | ||
version "1.0.3" | ||
resolved "https://registry.yarnpkg.com/globalthis/-/globalthis-1.0.3.tgz#5852882a52b80dc301b0660273e1ed082f0b6ccf" | ||
integrity sha512-sFdI5LyBiNTHjRd7cGPWapiHWMOXKyuBNX/cWJ3NfzrZQVa8GI/8cofCl74AOVqq9W5kNmguTIzJ/1s2gyI9wA== | ||
dependencies: | ||
define-properties "^1.1.3" | ||
|
||
[email protected]: | ||
version "0.1.0" | ||
resolved "https://registry.yarnpkg.com/globalyzer/-/globalyzer-0.1.0.tgz#cb76da79555669a1519d5a8edf093afaa0bf1465" | ||
|
@@ -15104,6 +15138,16 @@ http-signature@~1.2.0: | |
jsprim "^1.2.2" | ||
sshpk "^1.7.0" | ||
|
||
http-terminator@^3.2.0: | ||
version "3.2.0" | ||
resolved "https://registry.yarnpkg.com/http-terminator/-/http-terminator-3.2.0.tgz#bc158d2694b733ca4fbf22a35065a81a609fb3e9" | ||
integrity sha512-JLjck1EzPaWjsmIf8bziM3p9fgR1Y3JoUKAkyYEbZmFrIvJM6I8vVJfBGWlEtV9IWOvzNnaTtjuwZeBY2kwB4g== | ||
dependencies: | ||
delay "^5.0.0" | ||
p-wait-for "^3.2.0" | ||
roarr "^7.0.4" | ||
type-fest "^2.3.3" | ||
|
||
[email protected], https-browserify@^1.0.0: | ||
version "1.0.0" | ||
resolved "https://registry.yarnpkg.com/https-browserify/-/https-browserify-1.0.0.tgz#ec06c10e0a34c0f2faf199f7fd7fc78fffd03c73" | ||
|
@@ -20607,7 +20651,7 @@ p-timeout@^2.0.1: | |
dependencies: | ||
p-finally "^1.0.0" | ||
|
||
p-timeout@^3.1.0, p-timeout@^3.2.0: | ||
p-timeout@^3.0.0, p-timeout@^3.1.0, p-timeout@^3.2.0: | ||
version "3.2.0" | ||
resolved "https://registry.yarnpkg.com/p-timeout/-/p-timeout-3.2.0.tgz#c7e17abc971d2a7962ef83626b35d635acf23dfe" | ||
integrity sha512-rhIwUycgwwKcP9yTOOFK/AKsAopjjCakVqLHePO3CC6Mir1Z99xT+R63jZxAT5lFZLa2inS5h+ZS2GvR99/FBg== | ||
|
@@ -20629,6 +20673,13 @@ p-try@^2.0.0: | |
resolved "https://registry.yarnpkg.com/p-try/-/p-try-2.2.0.tgz#cb2868540e313d61de58fafbe35ce9004d5540e6" | ||
integrity sha512-R4nPAVTAU0B9D35/Gk3uJf/7XYbQcyohSKdvAxIRSNghFl4e71hVoGnBNQz9cWaXxO2I10KTC+3jMdvvoKw6dQ== | ||
|
||
p-wait-for@^3.2.0: | ||
version "3.2.0" | ||
resolved "https://registry.yarnpkg.com/p-wait-for/-/p-wait-for-3.2.0.tgz#640429bcabf3b0dd9f492c31539c5718cb6a3f1f" | ||
integrity sha512-wpgERjNkLrBiFmkMEjuZJEWKKDrNfHCKA1OhyN1wg1FrLkULbviEy6py1AyJUgZ72YWFbZ38FIpnqvVqAlDUwA== | ||
dependencies: | ||
p-timeout "^3.0.0" | ||
|
||
[email protected]: | ||
version "2.1.1" | ||
resolved "https://registry.npmjs.org/p-waterfall/-/p-waterfall-2.1.1.tgz#63153a774f472ccdc4eb281cdb2967fcf158b2ee" | ||
|
@@ -21277,7 +21328,7 @@ [email protected], pnp-webpack-plugin@^1.6.4: | |
dependencies: | ||
ts-pnp "^1.1.6" | ||
|
||
portfinder@^1.0.26, portfinder@^1.0.28, portfinder@^1.0.29: | ||
portfinder@^1.0.26, portfinder@^1.0.29: | ||
version "1.0.32" | ||
resolved "https://registry.yarnpkg.com/portfinder/-/portfinder-1.0.32.tgz#2fe1b9e58389712429dc2bea5beb2146146c7f81" | ||
integrity sha512-on2ZJVVDXRADWE6jnQaX0ioEylzgBpQk8r55NE4wjXW1ZxO+BgDlY6DXwj20i0V8eB4SenDQ00WEaxfiIQPcxg== | ||
|
@@ -23753,7 +23804,7 @@ [email protected]: | |
convert-source-map "^0.3.3" | ||
css "^2.0.0" | ||
|
||
rfdc@^1.1.4, rfdc@^1.3.0: | ||
rfdc@^1.1.4, rfdc@^1.2.0, rfdc@^1.3.0: | ||
version "1.3.0" | ||
resolved "https://registry.yarnpkg.com/rfdc/-/rfdc-1.3.0.tgz#d0b7c441ab2720d05dc4cf26e01c89631d9da08b" | ||
integrity sha512-V2hovdzFbOi77/WajaSMXk2OLm+xNIeQdMMuB7icj7bk6zi2F8GGAxigcnDFpJHbNyNcgyJDiP+8nOrY5cZGrA== | ||
|
@@ -23811,6 +23862,18 @@ ripemd160@^2.0.0, ripemd160@^2.0.1: | |
hash-base "^3.0.0" | ||
inherits "^2.0.1" | ||
|
||
roarr@^7.0.4: | ||
version "7.15.0" | ||
resolved "https://registry.yarnpkg.com/roarr/-/roarr-7.15.0.tgz#09b792f0cd31b4a7f91030bb1c47550ceec98ee4" | ||
integrity sha512-CV9WefQfUXTX6wr8CrEMhfNef3sjIt9wNhE/5PNu4tNWsaoDNDXqq+OGn/RW9A1UPb0qc7FQlswXRaJJJsqn8A== | ||
dependencies: | ||
boolean "^3.1.4" | ||
fast-json-stringify "^2.7.10" | ||
fast-printf "^1.6.9" | ||
globalthis "^1.0.2" | ||
safe-stable-stringify "^2.4.1" | ||
semver-compare "^1.0.0" | ||
|
||
[email protected]: | ||
version "3.2.1" | ||
resolved "https://registry.yarnpkg.com/rollup-plugin-cleanup/-/rollup-plugin-cleanup-3.2.1.tgz#8cbc92ecf58babd7c210051929797f137bbf777c" | ||
|
@@ -23999,6 +24062,11 @@ safe-stable-stringify@^2.3.1: | |
resolved "https://registry.yarnpkg.com/safe-stable-stringify/-/safe-stable-stringify-2.4.1.tgz#34694bd8a30575b7f94792aa51527551bd733d61" | ||
integrity sha512-dVHE6bMtS/bnL2mwualjc6IxEv1F+OCUpA46pKUj6F8uDbUM0jCCulPqRNPSnWwGNKx5etqMjZYdXtrm5KJZGA== | ||
|
||
safe-stable-stringify@^2.4.1: | ||
version "2.4.3" | ||
resolved "https://registry.yarnpkg.com/safe-stable-stringify/-/safe-stable-stringify-2.4.3.tgz#138c84b6f6edb3db5f8ef3ef7115b8f55ccbf886" | ||
integrity sha512-e2bDA2WJT0wxseVd4lsDP4+3ONX6HpMXQa1ZhFQ7SU+GjvORCmShbCMltrtIDfkYhVHrOcPtj+KhmDBdPdZD1g== | ||
|
||
"safer-buffer@>= 2.1.2 < 3", "safer-buffer@>= 2.1.2 < 3.0.0", safer-buffer@^2.0.2, safer-buffer@^2.1.0, safer-buffer@^2.1.2, safer-buffer@~2.1.0: | ||
version "2.1.2" | ||
resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a" | ||
|
@@ -24182,6 +24250,11 @@ selfsigned@^1.10.7, selfsigned@^1.10.8: | |
dependencies: | ||
node-forge "^0.10.0" | ||
|
||
semver-compare@^1.0.0: | ||
version "1.0.0" | ||
resolved "https://registry.yarnpkg.com/semver-compare/-/semver-compare-1.0.0.tgz#0dee216a1c941ab37e9efb1788f6afc5ff5537fc" | ||
integrity sha512-YM3/ITh2MJ5MtzaM429anh+x2jiLVjqILF4m4oyQB18W7Ggea7BfqdH/wGMK7dDiMghv/6WG7znWMwUDzJiXow== | ||
|
||
semver-diff@^3.1.1: | ||
version "3.1.1" | ||
resolved "https://registry.yarnpkg.com/semver-diff/-/semver-diff-3.1.1.tgz#05f77ce59f325e00e2706afd67bb506ddb1ca32b" | ||
|
@@ -25268,6 +25341,11 @@ string-length@^4.0.1: | |
char-regex "^1.0.2" | ||
strip-ansi "^6.0.0" | ||
|
||
string-similarity@^4.0.1: | ||
version "4.0.4" | ||
resolved "https://registry.yarnpkg.com/string-similarity/-/string-similarity-4.0.4.tgz#42d01ab0b34660ea8a018da8f56a3309bb8b2a5b" | ||
integrity sha512-/q/8Q4Bl4ZKAPjj8WerIBJWALKkaPRfrvhfF8k/B23i4nzrlRj2/go1m90In7nG/3XDSbOo0+pu6RvCTM9RGMQ== | ||
|
||
string-template@~0.2.1: | ||
version "0.2.1" | ||
resolved "https://registry.yarnpkg.com/string-template/-/string-template-0.2.1.tgz#42932e598a352d01fc22ec3367d9d84eec6c9add" | ||
|
@@ -26598,6 +26676,11 @@ type-fest@^0.8.1: | |
resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.8.1.tgz#09e249ebde851d3b1e48d27c105444667f17b83d" | ||
integrity sha512-4dbzIzqvjtgiM5rw1k5rEHtBANKmdudhGyBEajN01fEyhaAIhsoKNy6y7+IN93IfpFtwY9iqi7kD+xwKhQsNJA== | ||
|
||
type-fest@^2.3.3: | ||
version "2.19.0" | ||
resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-2.19.0.tgz#88068015bb33036a598b952e55e9311a60fd3a9b" | ||
integrity sha512-RAH822pAdBgcNMAfWnCBU3CFZcfZ/i1eZjwFU/dsLKumyuuP3niueg2UAukXYF0E2AAoc82ZSSf9J0WQBinzHA== | ||
|
||
type-is@~1.6.18: | ||
version "1.6.18" | ||
resolved "https://registry.yarnpkg.com/type-is/-/type-is-1.6.18.tgz#4e552cd05df09467dcbc4ef739de89f2cf37c131" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be clear, do we not need to call
this.server.close()
anymore, is that handled by the terminator?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's handled by it -> https://github.com/gajus/http-terminator/blob/aabca4751552e983f8a59ba896b7fb58ce3b4087/src/factories/createInternalHttpTerminator.ts#L156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍