fix(replay): Ensure multi click has correct timestamps #8591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
approved these changes
Jul 19, 2023
| @@ -125,7 +126,7 @@ export class ClickDetector implements ReplayClickDetector { | |||
| } | |||
|
|
|||
| const newClick: Click = { | |||
| timestamp: breadcrumb.timestamp, | |||
| timestamp: timestampToS(breadcrumb.timestamp), | |||
There was a problem hiding this comment.
should we use full name here?
Suggested change
| timestamp: timestampToS(breadcrumb.timestamp), | |
| timestamp: timestampToSeconds(breadcrumb.timestamp), |
There was a problem hiding this comment.
I used this to be parallel to timestampToMs, but 🤷 no strong feelings? WDYT?
There was a problem hiding this comment.
Yeah ToS just looks a bit funny to me, nbd
billyvg
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this actually fixes the problem with sometimes incorrect click count, but it def. makes sense to have this safeguard, I'd say.