feat(core) : Truncate the cause message to a maxLengthValue of 250 #8592
Conversation
|
Related to this issue : #8580 |
ziyad-elabid-nw
force-pushed
the
fix/truncate-cause-message-to-max-length-value
branch
2 times, most recently
from
d6722a7
to
20f43a3
Compare
ziyad-elabid-nw
force-pushed
the
fix/truncate-cause-message-to-max-length-value
branch
from
20f43a3
to
a0ce78d
Compare
|
Hi @ziyad-elabid-nw, seems like we were working on the same issue at the same time (#8593) 😅 I believe #8593 solves this more generally, not just for the react error boundary. AFAICT the error boundary basically relies on the Regardless, thanks for contributing! :) |
| @@ -79,6 +80,7 @@ function setCause(error: Error & { cause?: Error }, cause: Error): void { | |||
| seenErrors.set(error, true); | |||
| return recurse(error.cause, cause); | |||
| } | |||
| cause.message = truncate(cause.message, MAX_VALUE_LENGTH); | |||
There was a problem hiding this comment.
No action required at this time, see my other comment but:
The maxValueLength can be configured in the SDK's init options. We should respect that and only fall back to MAX_VALUE_LENGTH if the option is not set.
Hello @Lms24, i took a glance on your PR, i got what you mean 👍 better to close it Have a nice day 💯 |
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).