Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(remix): Skip all firefox tests #8662

Merged
merged 2 commits into from
Jul 27, 2023
Merged

test(remix): Skip all firefox tests #8662

merged 2 commits into from
Jul 27, 2023

Conversation

AbhiPrasad
Copy link
Member

Using the same approach as #8603, we skip all firefox tests in remix integration tests unless they are explicitly opted in.

resolves #8661

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 27, 2023 14:22
@AbhiPrasad AbhiPrasad merged commit 40fe2a0 into develop Jul 27, 2023
47 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remix-firefox-flake branch July 27, 2023 14:37
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@onurtemizkan onurtemizkan Awaiting requested review from onurtemizkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: Timeout for [firefox] › test/integration/test/client/root-loader.test.ts:39:5
2 participants
@AbhiPrasad @Lms24