Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Improve status logging #8709

Merged
merged 1 commit into from
Aug 3, 2023
Merged

ref(replay): Improve status logging #8709

merged 1 commit into from
Aug 3, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 2, 2023

This streamlines & improves logging for replay status, adding more logs for certain things to be better able to see what's going on, and adapting the traceInternals setting to result in console breadcrumbs being added (which should show up both in replay and for e.g. sentry errors etc).

While at it I also fixed some any eslint warnings in replay.

ref: #8400

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Aug 2, 2023
@mydea mydea requested a review from billyvg August 2, 2023 08:58
@mydea mydea self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (0%)
@sentry/browser - Webpack (gzipped) 21.95 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.84 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.33 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.06 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.41 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.28 KB (+0.19% 🔺)
@sentry/react - Webpack (gzipped) 21.96 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.04 KB (+0.13% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.89 KB (0%)

@mydea mydea force-pushed the fn/replay-logs branch 2 times, most recently from fb9f13e to 43363e8 Compare August 2, 2023 09:34
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea mydea merged commit 60c1081 into develop Aug 3, 2023
72 checks passed
@mydea mydea deleted the fn/replay-logs branch August 3, 2023 06:47
@Lms24
Copy link
Member

Lms24 commented Aug 3, 2023

Don't mind me, just passing through:
I was just about to comment that this might cause the logInfo calls not to be tree-shaken out if __DEBUG_BUILD__ was set but at least rollup will still eliminate these calls. Pretty impressive!

EDIT: I wonder though if it works for Webpack too 🤔 if it does, we might be able to do the same thing in our logger instead of always guarding the calls 🤔 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants