fix(replay): Ensure buffer sessions end after capturing an error

[mydea]

We haven't been persisting the shouldRefresh property of the session. This combined with the fact that we do not update the sampled field on the session to session when an error occurs, but keep it at buffer, means that if a user reloads the page or the session is otherwise re-fetched from sessionStorage, if previously an error occurs, we'll keep buffering forever again (like for a "fresh" buffer session), and if an error happens we convert it again to a session session, but since the session ID was never updated this will be "added" to the previous session instead.

I made a reproduction test that failed before and works after this fix.

Fixes #8400

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	75.11 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	31.41 KB (0%)
@sentry/browser - Webpack (gzipped)	21.95 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	69.85 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	28.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)	20.33 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	221.08 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	86 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	60.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	30.41 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	65.17 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped)	21.96 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	92.94 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped)	50.89 KB (0%)

[billyvg]

Ah nice catch!