-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 7.72.0 #9118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been having issues with the `setTimeout` return type in the node SDK, mostly when running tests: ``` Property 'unref' does not exist on type 'number'. ``` It turns out we've got dom lib types in the base tsconfig which means these have ended up in node SDK. This PR ensures we only have `es6` and no dom lib types and then fixes all the resulting errors.
[Gitflow] Merge master into develop
This PR adds ANR detection for Node via a forked child process. The child process runs the same entry point as the main app. To ensure that the main app code does not run in the child process, we use a promise that only resolves in the main process. When the `captureStackTrace` option is enabled, debugging is enabled in the main app process and the child process uses WebSockets to capture stack traces via the v8 inspector API. Overhead is expected to be minimal. With no ANR detected, the only overhead in the main app process is polling the child process over IPC by default every 50ms. The ANR child process consumes around 50-60 MB or RAM and simply keeps track of the polling. Once ANR has been detected, the main process will get paused briefly in the debugger to capture a stack trace frames. At this point, the event loop has been blocked for seconds so the debugging overhead can be considered negligible. Once an ANR event has been reported, the child process exits to prevent further duplicate events. ```ts import { init, enableANRDetection } from '@sentry/node'; init({ dsn: "__DSN__" }); // ESM supports top-level await await enableANRDetection({ captureStackTrace: true }); runApp(); // for CJS you'll need then enableANRDetection({ captureStackTrace: true }).then(() => { runApp(); }) ``` Co-authored-by: Abhijeet Prasad <[email protected]>
This was missing currently, so for correctness adding the resource info here.
… webpack will resolve (#9114)
size-limit report 📦
|
AbhiPrasad
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor because of ANR changes