Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(integrations): Remove offline integration #9456

Merged
merged 5 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dev-packages/rollup-utils/plugins/bundlePlugins.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ export function makeTerserPlugin() {
reserved: [
// ...except for `_experiments`, which we want to remain usable from the outside
'_experiments',
// ...except for some localforage internals, which if we replaced them would break the localforage package
// with the error "Error: Custom driver not compliant": https://github.com/getsentry/sentry-javascript/issues/5527.
// Reference for which fields are affected: https://localforage.github.io/localForage/ (ctrl-f for "_")
'_driver',
'_initStorage',
'_support',
// We want to keep some replay fields unmangled to enable integration tests to access them
'_replay',
'_canvas',
Expand Down
3 changes: 1 addition & 2 deletions packages/integrations/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
"dependencies": {
"@sentry/core": "7.100.0",
"@sentry/types": "7.100.0",
"@sentry/utils": "7.100.0",
"localforage": "^1.8.1"
"@sentry/utils": "7.100.0"
},
"devDependencies": {
"@sentry/browser": "7.100.0",
Expand Down
8 changes: 1 addition & 7 deletions packages/integrations/rollup.bundle.config.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import commonjs from '@rollup/plugin-commonjs';

import { insertAt, makeBaseBundleConfig, makeBundleConfigVariants } from '@sentry-internal/rollup-utils';
import { makeBaseBundleConfig, makeBundleConfigVariants } from '@sentry-internal/rollup-utils';

const builds = [];

Expand All @@ -15,10 +13,6 @@ const baseBundleConfig = makeBaseBundleConfig({
outputFileBase: ({ name: entrypoint }) => `bundles/${entrypoint}${jsVersion === 'es5' ? '.es5' : ''}`,
});

// TODO We only need `commonjs` for localforage (used in the offline plugin). Once that's fixed, this can come out.
// CommonJS plugin docs: https://github.com/rollup/plugins/tree/master/packages/commonjs
baseBundleConfig.plugins = insertAt(baseBundleConfig.plugins, -2, commonjs());

// this makes non-minified, minified, and minified-with-debug-logging versions of each bundle
builds.push(...makeBundleConfigVariants(baseBundleConfig));

Expand Down
1 change: 0 additions & 1 deletion packages/integrations/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ export { CaptureConsole, captureConsoleIntegration } from './captureconsole';
export { Debug, debugIntegration } from './debug';
export { Dedupe, dedupeIntegration } from './dedupe';
export { ExtraErrorData, extraErrorDataIntegration } from './extraerrordata';
export { Offline } from './offline';
export { ReportingObserver, reportingObserverIntegration } from './reportingobserver';
export { RewriteFrames, rewriteFramesIntegration } from './rewriteframes';
export { SessionTiming, sessionTimingIntegration } from './sessiontiming';
Expand Down
181 changes: 0 additions & 181 deletions packages/integrations/src/offline.ts

This file was deleted.

Loading
Loading