Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crons): Switch to enum as a shape Discriminator in clock tasks #342

Conversation

evanpurkhiser
Copy link
Member

This is due to the issue Tencent/rapidjson#2314

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 24, 2024 18:07
@evanpurkhiser evanpurkhiser requested review from lynnagara and removed request for a team October 24, 2024 18:07
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.111 (upgrade)

latest version: 0.1.113

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

@evanpurkhiser evanpurkhiser merged commit 3868aea into main Oct 24, 2024
14 of 17 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-crons-switch-to-enum-as-a-shape-discriminator-in-clock-tasks branch October 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants