Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): Include region in uptime results #363

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

wedamija
Copy link
Member

Add region to uptime results, so that we're able to track where this result came from.

Add `region` to uptime results, so that we're able to track where this result came from.
@wedamija wedamija requested a review from a team as a code owner December 30, 2024 22:58
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

latest version: 0.1.125

changes considered breaking

schemas/uptime-results.v1.schema.json

  • Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema.

    {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "region"}}}
    

⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:

  • If consumers already require these invariants in practice, and you're
    just adjusting the JSON schema to reality, ignore this warning.

  • If you know what you are doing, this change could potentially be rolled out
    to producers first, but that's not a flow we support.

@wedamija wedamija merged commit 9d31b45 into main Jan 2, 2025
15 of 16 checks passed
@wedamija wedamija deleted the danf/uptime-results-region branch January 2, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants