Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry dependency bot #124

Merged
merged 22 commits into from
Oct 27, 2023
Merged

Add sentry dependency bot #124

merged 22 commits into from
Oct 27, 2023

Conversation

buenaflor
Copy link
Contributor

📜 Description

💡 Motivation and Context

Closes #123

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor
Copy link
Contributor Author

Example: #127

@buenaflor buenaflor marked this pull request as ready for review October 25, 2023 12:31
@buenaflor buenaflor requested a review from romtsn as a code owner October 25, 2023 12:31
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@krystofwoldrich
Copy link
Member

Nit: The files are missing a new empty line at the end.

@buenaflor
Copy link
Contributor Author

@krystofwoldrich should be improved now. also GitHub is somehow not showing the newlines at the end of files

@krystofwoldrich
Copy link
Member

@buenaflor Yeah, it only shows when the lines at the end are missing.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🚀

@krystofwoldrich krystofwoldrich merged commit 005bdc1 into main Oct 27, 2023
@krystofwoldrich krystofwoldrich deleted the deps/add-bot branch October 27, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency bot for bumping Cocoa and Java/Android SDKs
2 participants