Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry.isEnabled() to common code #273

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Add Sentry.isEnabled() to common code #273

merged 7 commits into from
Oct 7, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Sep 27, 2024

📜 Description

Add bridge toisEnabled()

💡 Motivation and Context

Closes #272

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner September 27, 2024 21:05
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 33d13a7

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.52%. Comparing base (7715854) to head (33d13a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   75.43%   75.52%   +0.08%     
==========================================
  Files          38       38              
  Lines         574      576       +2     
  Branches       85       85              
==========================================
+ Hits          433      435       +2     
  Misses         96       96              
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor merged commit 27c2e03 into main Oct 7, 2024
11 checks passed
@buenaflor buenaflor deleted the feat/add-isEnabled branch October 7, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose isEnabled from underlying Sentry SDKs
3 participants