Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove auto bot format #276

Merged
merged 2 commits into from
Oct 7, 2024
Merged

ci: remove auto bot format #276

merged 2 commits into from
Oct 7, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Sep 30, 2024

The bot will run auto formatting but the CI will freeze because bots don't have permission to run CI so someone has to re-trigger the CI with another change which is annoying.

The analyze workflow will fail anyway if formatting is off, it's more convenient at this point to just format locally and then push manually

#skip-changelog

@buenaflor buenaflor requested a review from romtsn as a code owner September 30, 2024 13:11
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (6ed4593) to head (44685cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files          38       38           
  Lines         574      574           
  Branches       85       85           
=======================================
  Hits          433      433           
  Misses         96       96           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change, but ideally we'd fix the bot somehow that it does not require a retrigger 😅 like using bruno-garcia's token lol

@buenaflor buenaflor enabled auto-merge (squash) October 7, 2024 22:38
@buenaflor buenaflor merged commit 7715854 into main Oct 7, 2024
11 checks passed
@buenaflor buenaflor deleted the ci/remove-format-workflow branch October 7, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants