fix: beforeSend overriding default release even if it was not set #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 79.92% 79.97% +0.04%
==========================================
Files 44 44
Lines 812 814 +2
Branches 108 110 +2
==========================================
+ Hits 649 651 +2
Misses 107 107
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romtsn
reviewed
Apr 25, 2025
...in-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/util/ApplyIfChanged.kt
Outdated
Show resolved
Hide resolved
|
I'll update this PR, let's fix it only for the release field now. I'm not even sure if the other fields need to be fixed like that as well |
buenaflor
commented
May 2, 2025
|
|
||
| // init with a SentryLevel as a workaround for: | ||
| // Unable to call non-designated initializer as super constructor | ||
| private class FakeSentryEvent : CocoaSentryEvent(Internal.Sentry.kSentryLevelFatal) { |
There was a problem hiding this comment.
can only test on cocoa - on java the SentryEvent is final and we don't use a mocking framework yet
|
@romtsn is this good to go? |
buenaflor
changed the title
|
Updated dist as well. We don't expose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We need to keep the KMP event model in sync with the native one. Users mainly edit events in KMP hooks like beforeSend, so we must track whether each field was actually modified:
If a field was changed, propagate the new value to the native event.• If it was untouched, leave the native default in place.
Previously we overwrote native defaults with null values by default e.g., Cocoa’s auto‑detected release was not working since we set a null release
💡 Motivation and Context
Fixes #337
💚 How did you test it?
TBD unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps