Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto-Install for graphql-22 #100

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Oct 28, 2024

📜 Description

Add support for parsing versions with only major and minor parts (e.g. 22.5)
Add Auto-Install strategy for graphql-22

💡 Motivation and Context

Fixes #3757

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2b1a1c1

@lbloder lbloder marked this pull request as ready for review October 28, 2024 10:37
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

&& isModuleAvailable(resolvedArtifacts, SENTRY_SPRING_6_ID)
&& isModuleAvailable(resolvedArtifacts, SENTRY_SPRING_BOOT_2_ID)
&& isModuleAvailable(resolvedArtifacts, SENTRY_SPRING_BOOT_3_ID));
|| isModuleAvailable(resolvedArtifacts, SENTRY_SPRING_6_ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sentry-graphql-22 in auto install maven plugin
2 participants