Use SENTRY_SPOTLIGHT as default value for Spotlight options
#1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
spotlight-url-from-env
branch
from
6b9a5fd
to
235f9b7
Compare
stayallive
force-pushed
the
spotlight-url-from-env
branch
from
235f9b7
to
fd5d15d
Compare
BYK
reviewed
Nov 14, 2024
| @@ -1187,7 +1191,7 @@ private function configureOptions(OptionsResolver $resolver): void | |||
| $resolver->setAllowedTypes('in_app_exclude', 'string[]'); | |||
| $resolver->setAllowedTypes('in_app_include', 'string[]'); | |||
| $resolver->setAllowedTypes('logger', ['null', LoggerInterface::class]); | |||
| $resolver->setAllowedTypes('spotlight', 'bool'); | |||
| $resolver->setAllowedTypes('spotlight', ['bool', 'string', 'null']); | |||
| $resolver->setAllowedTypes('spotlight_url', 'string'); | |||
There was a problem hiding this comment.
This is probably obsolete now. (this referring to spotlight_url)
There was a problem hiding this comment.
Yes, this should be marked as deprecated, can't remove it yet but will be slated to be removed in 5.x will update the code to mark it as such!
Comment on lines
+675
to
+683
| return [ | ||
| ['', false, $defaultSpotlightUrl], | ||
| ['true', true, $defaultSpotlightUrl], | ||
| ['1', true, $defaultSpotlightUrl], | ||
| ['false', false, $defaultSpotlightUrl], | ||
| ['0', false, $defaultSpotlightUrl], | ||
| ['null', false, $defaultSpotlightUrl], | ||
| ['http://localhost:1234', true, 'http://localhost:1234'], | ||
| ['some invalid looking value', false, $defaultSpotlightUrl], |
There was a problem hiding this comment.
This is the logic we used in Python SDK first (and then ported to JS): https://github.com/getsentry/sentry-python/pull/3443/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2R74-R75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads
SENTRY_SPOTLIGHTenvironment variable as source of truth and also allows passing the URL directly to thespotlightoption.Related getsentry/spotlight#545