Fixed deprecated transaction creation

getsentry · Dec 5, 2023 · 0420460 · 0420460
1 parent 34d91ac
commit 0420460
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/sentry_sdk/scope.py b/sentry_sdk/scope.py
@@ -719,8 +719,7 @@ def start_span(self, span=None, instrumenter=INSTRUMENTER.SENTRY, **kwargs):
 
         For supported `**kwargs` see :py:class:`sentry_sdk.tracing.Span`.
         """
-        hub = kwargs.pop("hub", None)
-        client = kwargs.pop("client", None)
+        client = kwargs.get("client", None)
 
         configuration_instrumenter = client and client.options["instrumenter"]
 
@@ -739,7 +738,7 @@ def start_span(self, span=None, instrumenter=INSTRUMENTER.SENTRY, **kwargs):
 
             if isinstance(span, Transaction):
                 logger.warning(deprecation_msg)
-                return self.start_transaction(span)
+                return self.start_transaction(span, **kwargs)
 
             if "transaction" in kwargs:
                 logger.warning(deprecation_msg)
@@ -753,7 +752,7 @@ def start_span(self, span=None, instrumenter=INSTRUMENTER.SENTRY, **kwargs):
             logger.warning(deprecation_msg)
             return span
 
-        kwargs.setdefault("hub", hub)
+        kwargs.pop("client")
 
         active_span = self.span
         if active_span is not None: