Refactoring

getsentry · Jun 21, 2023 · 23dbfe4 · 23dbfe4
1 parent 3fe8b83
commit 23dbfe4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/sentry_sdk/_compat.py b/sentry_sdk/_compat.py
@@ -2,6 +2,8 @@
 
 from sentry_sdk._types import TYPE_CHECKING
 
+from sentry_sdk.consts import FALSE_VALUES
+
 if TYPE_CHECKING:
     from typing import Optional
     from typing import Tuple
@@ -82,7 +84,7 @@ def check_thread_support():
     if "threads" in opt:
         return
 
-    if str(opt.get("enable-threads", "0")).lower() in ("false", "off", "no", "0"):
+    if str(opt.get("enable-threads", "0")).lower() in FALSE_VALUES:
         from warnings import warn
 
         warn(

diff --git a/sentry_sdk/consts.py b/sentry_sdk/consts.py
@@ -45,6 +45,14 @@
 
 MATCH_ALL = r".*"
 
+FALSE_VALUES = [
+    "false",
+    "no",
+    "off",
+    "n",
+    "0",
+]
+
 
 class INSTRUMENTER:
     SENTRY = "sentry"

diff --git a/sentry_sdk/scope.py b/sentry_sdk/scope.py
@@ -20,6 +20,8 @@
 from sentry_sdk._types import TYPE_CHECKING
 from sentry_sdk.utils import logger, capture_internal_exceptions
 
+from sentry_sdk.consts import FALSE_VALUES
+
 
 if TYPE_CHECKING:
     from typing import Any
@@ -135,18 +137,10 @@ def _load_trace_data_from_env(self):
         """
         incoming_trace_information = None
 
-        false_values = [
-            "false",
-            "no",
-            "off",
-            "n",
-            "0",
-        ]
-
         sentry_use_environment = (
             os.environ.get("SENTRY_USE_ENVIRONMENT") or ""
         ).lower()
-        use_environment = sentry_use_environment not in false_values
+        use_environment = sentry_use_environment not in FALSE_VALUES
         if use_environment:
             incoming_trace_information = {}