fix(cache): Fix key_as_string (#3132)

getsentry · Jun 5, 2024 · 8f80dfe · 8f80dfe
1 parent c2c7896
commit 8f80dfe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/sentry_sdk/integrations/redis/utils.py b/sentry_sdk/integrations/redis/utils.py
@@ -52,7 +52,7 @@ def _safe_decode(key):
         except UnicodeDecodeError:
             return ""
 
-    return key
+    return str(key)
 
 
 def _key_as_string(key):

diff --git a/tests/integrations/redis/test_redis_cache_module.py b/tests/integrations/redis/test_redis_cache_module.py
@@ -244,6 +244,12 @@ def test_cache_data(sentry_init, capture_events):
             None,
             (b"\x00c\x0f\xeaC\xe1L\x1c\xbff\xcb\xcc\xc1\xed\xc6\t",),
         ),
+        (
+            "get",
+            [123],
+            None,
+            (123,),
+        ),
     ],
 )
 def test_get_safe_key(method_name, args, kwargs, expected_key):
@@ -266,6 +272,9 @@ def test_get_safe_key(method_name, args, kwargs, expected_key):
         ),
         (["bla", "blub", "foo"], "bla, blub, foo"),
         ([uuid.uuid4().bytes], ""),
+        ({"key1": 1, "key2": 2}, "key1, key2"),
+        (1, "1"),
+        ([1, 2, 3, b"hello"], "1, 2, 3, hello"),
     ],
 )
 def test_key_as_string(key, expected_key):