Skip to content

Commit

Permalink
Make span.finish work
Browse files Browse the repository at this point in the history
  • Loading branch information
sl0thentr0py committed Sep 23, 2024
1 parent 13441e3 commit b8155ac
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions sentry_sdk/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ def __enter__(self):

def __exit__(self, ty, value, tb):
# type: (Optional[Any], Optional[Any], Optional[Any]) -> None
self._otel_span.end()
self.finish()
# XXX set status to error if unset and an exception occurred?
context.detach(self._ctx_token)

Expand Down Expand Up @@ -1524,9 +1524,16 @@ def is_success(self):
# type: () -> bool
return self._otel_span.status.code == StatusCode.OK

def finish(self, scope=None, end_timestamp=None):
# type: (Optional[sentry_sdk.Scope], Optional[Union[float, datetime]]) -> Optional[str]
pass
def finish(self, end_timestamp=None):
# type: (Optional[Union[float, datetime]]) -> Optional[str]
if end_timestamp is not None:
from sentry_sdk.integrations.opentelemetry.utils import (
convert_to_otel_timestamp,
)

self._otel_span.end(convert_to_otel_timestamp(end_timestamp))
else:
self._otel_span.end()

def to_json(self):
# type: () -> dict[str, Any]
Expand Down

0 comments on commit b8155ac

Please sign in to comment.