fix: review 2 changes

getsentry · Jun 23, 2023 · c4e3664 · c4e3664
1 parent 3aa5f01
commit c4e3664
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/sentry_sdk/integrations/aiohttp.py b/sentry_sdk/integrations/aiohttp.py
@@ -23,6 +23,7 @@
     transaction_from_function,
     HAS_REAL_CONTEXTVARS,
     CONTEXTVARS_ERROR_MESSAGE,
+    SENSITIVE_DATA_SUBSTITUTE,
     AnnotatedValue,
 )
 
@@ -203,14 +204,16 @@ async def on_request_start(session, trace_config_ctx, params):
             parsed_url = parse_url(str(params.url), sanitize=False)
 
         span = hub.start_span(
-            op=OP.HTTP_CLIENT, description="%s %s" % (method, parsed_url)
+            op=OP.HTTP_CLIENT,
+            description="%s %s"
+            % (method, parsed_url.url if parsed_url else SENSITIVE_DATA_SUBSTITUTE),
         )
         span.set_data(SPANDATA.HTTP_METHOD, method)
         span.set_data("url", parsed_url.url)
         span.set_data(SPANDATA.HTTP_QUERY, parsed_url.query)
         span.set_data(SPANDATA.HTTP_FRAGMENT, parsed_url.fragment)
 
-        if should_propagate_trace(hub, parsed_url.url):
+        if should_propagate_trace(hub, str(params.url)):
             for key, value in hub.iter_trace_propagation_headers(span):
                 logger.debug(
                     "[Tracing] Adding `{key}` header {value} to outgoing request to {url}.".format(