-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SOCKS proxies #1049
Labels
Enhancement
New feature or request
Comments
Roguelazer
added a commit
to Roguelazer/sentry-python
that referenced
this issue
Mar 10, 2021
Roguelazer
added a commit
to Roguelazer/sentry-python
that referenced
this issue
Mar 10, 2021
Roguelazer
added a commit
to Roguelazer/sentry-python
that referenced
this issue
Mar 10, 2021
I vote one. It is great that Rationale:
And then, here's some implementation options. How to designate proxy URLA. From I guess the members of sentry prefer B because #178 (comment) . @untitaker @ahmedetefy Could you let us know your thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If pysocks is available, urllib3 supports SOCKS proxies, but you can't use the
urllib3.ProxyManager
class and must instead useurllib3.contrib.socks.SOCKSProxyManager
. It would be very nice ifsentry_sdk.transport.HttpTransport
could detect a proxy set tosocks://
(or one of the many variants) and Do The Right Thing.The text was updated successfully, but these errors were encountered: