Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SOCKS proxies in sentry_sdk #1050

Merged
merged 12 commits into from
Jun 19, 2023
Merged

Conversation

Roguelazer
Copy link
Contributor

Fixes #1049

Not sure that this is the cleanest solution, but it sure seems to work.

@kenoss
Copy link

kenoss commented Jun 17, 2021

This PR is very useful. I'm not a maintainer of this repo but I'll note some points I found.

  1. About PySocks dependency.

urllib3 does not install PySocks by default.
In other words, after this PR, the users need to write dependencies both sentry_sdk and PySocks explicitly and separately, and urllib3 can't control what version of PySocks is installed.
setry_sdk uses extra_require already, and (AFAIK) it is better to do it.
(But, a little tricky. sentry_sdk[socks] should trigger urllib3[socks] rather than PySocks.)
Users will be able to install by pip install "sentry_sdk[socks]".

  1. About test.

This PR would be more great if it has tests, like https://github.com/getsentry/sentry-python/pull/838/files I guess.

@kenoss kenoss mentioned this pull request Jun 17, 2021
@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Roguelazer
Copy link
Contributor Author

reset the clock

@antonpirker antonpirker self-assigned this Jun 19, 2023
@antonpirker antonpirker merged commit 0792db2 into getsentry:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SOCKS proxies
5 participants