-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support SOCKS proxies in sentry_sdk #1050
Conversation
This PR is very useful. I'm not a maintainer of this repo but I'll note some points I found.
This PR would be more great if it has tests, like https://github.com/getsentry/sentry-python/pull/838/files I guess. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
reset the clock |
Fixes #1049
Not sure that this is the cleanest solution, but it sure seems to work.