Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load tracing information from environment #2176

Merged

Conversation

antonpirker
Copy link
Member

It should be able to continue a trace with trace information that was given to the python process over environment variables.

See this RFC for the spec:
https://github.com/getsentry/rfcs/blob/main/text/0071-continue-trace-over-process-boundaries.md

FIxes #1906

@antonpirker antonpirker marked this pull request as ready for review June 21, 2023 08:10
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits to consider, else lgtm

sentry_sdk/scope.py Outdated Show resolved Hide resolved
sentry_sdk/scope.py Outdated Show resolved Hide resolved
@antonpirker antonpirker merged commit e68161c into master Jun 22, 2023
243 of 244 checks passed
@antonpirker antonpirker deleted the antonpirker/load_tracing_information_from_environment2 branch June 22, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue trace from ENV vars
2 participants