Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3) Move tracing related functions from Hub to Scope #2558

Merged
merged 44 commits into from
Dec 19, 2023

Conversation

antonpirker
Copy link
Member

Moved some functionality from Hub to Client:

  • sorted some typing imports
  • moved get_traceparent from Hub to Scope
  • moved get_baggage from Hub to Scope
  • moved iter_trace_propagation_headers from Hub to Scope
  • moved trace_propagation_meta from Hub to Scope

This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Depends on: #2555 (please review the linked one first)

@antonpirker antonpirker changed the base branch from master to antonpirker/refactor-hub-capture December 1, 2023 12:46
@antonpirker antonpirker changed the title Move tracing related functions from Hub to Scope (3) Move tracing related functions from Hub to Scope Dec 4, 2023
@antonpirker antonpirker marked this pull request as ready for review December 5, 2023 09:26
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This stuff also fits better on the scope conceptually.

sentry_sdk/scope.py Outdated Show resolved Hide resolved
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is good because this stuff conceptually now belongs together with propagation context 👍

Moved some functionality from Hub to Client:

- moved `start_transaction` from Hub to Scope
- moved `start_span` from Hub to Scope
- moved `continue_trace` from Hub to Scope

This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Depends on: #2558 (please review the linked one first)
Base automatically changed from antonpirker/refactor-hub-capture to feat/new-scopes December 19, 2023 11:20
@antonpirker antonpirker merged commit 5f332e3 into feat/new-scopes Dec 19, 2023
63 of 64 checks passed
@antonpirker antonpirker deleted the antonpirker/refactor-hub-tracing branch December 19, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants