Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Baggage object on PropagationContext instead of DSC hash #3523

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 11, 2024

  • this is how we do it in the Transaction/Span while PropagationContext was only storing the DSC hash so there was an inconsistency
  • if we store DSC directly, we lose third party items (might be relevant for later propagation changes)

Copy link

codecov bot commented Sep 11, 2024

❌ 3432 Tests Failed:

Tests completed Failed Passed Skipped
16633 3432 13201 1445
View the top 3 failed tests by shortest run time
tests.integrations.celery.test_celery test_producer_span_data[redis]
Stack Traces | 0s run time
No failure message available
tests.integrations.celery.test_celery test_transaction_events[<lambda>1-error]
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sl0thentr0py sl0thentr0py force-pushed the neel/cleanup-prop-context-baggage branch from e273b4f to 77b8d23 Compare September 11, 2024 13:49
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. (and also cleaner)

Because the tests are broken atm we can not ensure if this changes behavior (Only form looking at it, I think it does not change any behavior)

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sl0thentr0py sl0thentr0py merged commit 682b652 into potel-base Sep 11, 2024
9 of 108 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/cleanup-prop-context-baggage branch September 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants