Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added name parameter to start_span() and deprecated description parameter. #3524

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Sep 11, 2024

To align our API with OpenTelementry. In OTel a span has no description but a name.

This only changes to user facing API, under the hood there is still everything using the description. (This will then be changed with OTel)

Docs PR: getsentry/sentry-docs#11332

Follow up PR that should be released at the same time: #3525

Fixes #3520

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (a581542) to head (5401ed2).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
+ Coverage   84.25%   84.28%   +0.02%     
==========================================
  Files         136      136              
  Lines       13895    13900       +5     
  Branches     2938     2940       +2     
==========================================
+ Hits        11707    11715       +8     
+ Misses       1458     1456       -2     
+ Partials      730      729       -1     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 88.04% <100.00%> (+0.05%) ⬆️
sentry_sdk/tracing.py 85.11% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

@antonpirker antonpirker changed the title Added name to start_span() and deprecated description. Added name parameter to start_span() and deprecated description parameter. Sep 12, 2024
@antonpirker antonpirker merged commit b1b16b0 into master Sep 12, 2024
124 checks passed
@antonpirker antonpirker deleted the antonpirker/start_span-name-description branch September 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add name as alias to description to start_span().
2 participants