Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing in CI #3557

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Sep 23, 2024

Using this PR to debug a test failure in #3550 which is only occurring in CI

szokeasaurusrex and others added 3 commits September 23, 2024 10:10
Improve `get_integration` typing to make it clear that we return an `Optional[Integration]`. Further, add overloads to specify that when called with some integration type `I` (i.e. `I` is a subclass of `Integration`), then `get_integration` guarantees a return value of `Optional[I]`.

These changes should enhance type safety by explicitly guaranteeing the existing behavior of `get_integration`.
@szokeasaurusrex szokeasaurusrex changed the title szokeasaurusrex/get integration typing debug Testing in CI Sep 23, 2024
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/get_integration-typing-debug branch from 97cdc55 to 7c9fca7 Compare September 23, 2024 13:06
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.63291% with 39 lines in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (26b86a5) to head (0746663).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/aws_lambda.py 16.66% 5 Missing ⚠️
sentry_sdk/integrations/django/__init__.py 20.00% 2 Missing and 2 partials ⚠️
sentry_sdk/integrations/gcp.py 0.00% 4 Missing ⚠️
sentry_sdk/integrations/cohere.py 50.00% 1 Missing and 2 partials ⚠️
sentry_sdk/integrations/openai.py 50.00% 1 Missing and 2 partials ⚠️
sentry_sdk/integrations/starlette.py 57.14% 1 Missing and 2 partials ⚠️
sentry_sdk/integrations/aiohttp.py 50.00% 1 Missing and 1 partial ⚠️
sentry_sdk/integrations/atexit.py 33.33% 1 Missing and 1 partial ⚠️
sentry_sdk/integrations/bottle.py 50.00% 1 Missing and 1 partial ⚠️
sentry_sdk/integrations/celery/__init__.py 33.33% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3557      +/-   ##
==========================================
- Coverage   84.49%   84.30%   -0.19%     
==========================================
  Files         133      133              
  Lines       13855    13885      +30     
  Branches     2930     2929       -1     
==========================================
- Hits        11707    11706       -1     
- Misses       1423     1440      +17     
- Partials      725      739      +14     
Files with missing lines Coverage Δ
sentry_sdk/client.py 83.49% <100.00%> (ø)
sentry_sdk/integrations/fastapi.py 90.00% <100.00%> (ø)
sentry_sdk/integrations/flask.py 86.99% <100.00%> (+0.10%) ⬆️
sentry_sdk/integrations/sanic.py 80.55% <100.00%> (ø)
sentry_sdk/integrations/sys_exit.py 100.00% <100.00%> (ø)
sentry_sdk/integrations/threading.py 98.21% <100.00%> (-1.79%) ⬇️
sentry_sdk/integrations/anthropic.py 82.85% <50.00%> (-0.17%) ⬇️
sentry_sdk/integrations/aiohttp.py 84.66% <50.00%> (-0.88%) ⬇️
sentry_sdk/integrations/atexit.py 71.87% <33.33%> (-6.25%) ⬇️
sentry_sdk/integrations/bottle.py 86.31% <50.00%> (-1.73%) ⬇️
... and 11 more

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant