Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): End http.client span on timeout #3723

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Zylphrex
Copy link
Member

If the http request times out, the http client span never gets finished. So make sure to finish it no matter what.

If the http request times out, the http client span never gets finished. So make
sure to finish it no matter what.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (4c1367b) to head (60bed50).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3723      +/-   ##
==========================================
- Coverage   84.28%   83.15%   -1.13%     
==========================================
  Files         133      133              
  Lines       14257    14476     +219     
  Branches     2405     2471      +66     
==========================================
+ Hits        12016    12037      +21     
- Misses       1490     1689     +199     
+ Partials      751      750       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/stdlib.py 99.20% <100.00%> (+<0.01%) ⬆️

... and 4 files with indirect coverage changes

@Zylphrex Zylphrex enabled auto-merge (squash) October 31, 2024 19:53
@Zylphrex Zylphrex merged commit 5e2d2cf into master Oct 31, 2024
135 of 136 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/end-http-client-span-on-timeout branch October 31, 2024 20:12
Zylphrex added a commit to getsentry/sentry that referenced this pull request Nov 8, 2024
Looking to get getsentry/sentry-python#3723 to
address instrumentation issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants