Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAI tests in POTel #3738

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Fix OpenAI tests in POTel #3738

merged 5 commits into from
Dec 20, 2024

Conversation

antonpirker
Copy link
Member

No description provided.

@antonpirker antonpirker changed the base branch from master to potel-base November 5, 2024 14:27
@@ -330,6 +330,7 @@ async def test_streaming_chat_completion_async(
pass # if tiktoken is not installed, we can't guarantee token usage will be calculated properly


@pytest.mark.forked
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fork tests that capture exceptions. (Somehow capturing exceptions messes up the next sentry_sdk.init() and capturing events/exeptions in following tests)

Copy link

codecov bot commented Nov 5, 2024

❌ 333 Tests Failed:

Tests completed Failed Passed Skipped
19795 333 19462 4449
View the top 3 failed tests by shortest run time
 tests.integrations.celery.integration_tests.test_celery_beat_cron_monitoring
Stack Traces | 0s run time
No failure message available
 tests.integrations.celery.test_celery_beat_crons
Stack Traces | 0s run time
No failure message available
 tests.integrations.celery.test_update_celery_task_headers
Stack Traces | 0s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@antonpirker antonpirker marked this pull request as draft December 4, 2024 14:42
@antonpirker antonpirker changed the title Fix OpenAI tests Fix OpenAI tests in POTel Dec 5, 2024
@antonpirker antonpirker marked this pull request as ready for review December 20, 2024 13:05
@antonpirker antonpirker merged commit 9e64b1d into potel-base Dec 20, 2024
76 of 110 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/openai branch December 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants