Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 #3783

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix flake8 #3783

merged 1 commit into from
Nov 15, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 15, 2024

Tiny PR with some flake8 fixes:

  • some extra imports

  • testing a removed util

  • ignoring sentry_sdk/integrations/aiohttp.py:393:33: E231 missing whitespace after ':' on this line

    url = f"{request.scheme}://{request.host}{request.path}"

    🙄

Original output:

linters: commands[0]> flake8 tests sentry_sdk
tests/test_utils.py:109:12: F821 undefined name 'datetime_from_isoformat'
tests/test_api.py:4:1: F401 'sentry_sdk' imported but unused
sentry_sdk/_init_implementation.py:1:1: F401 'warnings' imported but unused
sentry_sdk/integrations/aiohttp.py:393:33: E231 missing whitespace after ':'

Copy link

codecov bot commented Nov 15, 2024

❌ 1600 Tests Failed:

Tests completed Failed Passed Skipped
19820 1600 18220 4413
View the top 1 failed tests by shortest run time
tests.test_scope test_with_isolation_scope
Stack Traces | 0.001s run time
tests/test_scope.py:357: in test_with_isolation_scope
    assert scope is in_with_isolation_scope
E   assert <PotelScope id=0x7f1444fd37a0 name=None type=ScopeType.ISOLATION> is <Scope id=0x7f14482ceb20 name=None type=ScopeType.ISOLATION>
View the full list of 2 ❄️ flaky tests
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.16% (Passed 2 times, Failed 235 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }
tests.test_scope test_with_new_scope

Flake rate in main: 96.98% (Passed 8 times, Failed 257 times)

Stack Traces | 0.001s run time
tests/test_scope.py:587: in test_with_new_scope
    assert scope is in_with_current_scope
E   assert <PotelScope id=0x7fa16c8214f0 name=None type=ScopeType.CURRENT> is <Scope id=0x7fa1801aeac0 name=None type=ScopeType.CURRENT>

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sentrivana sentrivana marked this pull request as ready for review November 15, 2024 12:03
@sentrivana sentrivana merged commit c29382d into potel-base Nov 15, 2024
42 of 125 checks passed
@sentrivana sentrivana deleted the ivana/fix-flake8 branch November 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants