Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): Auto enable cache_spans for Spotlight on DEBUG #3791

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Nov 15, 2024

This patch enables cache_spans in Django integration automatically when Spotlight is enabled and DEBUG is set in Django settings.

This patch enables `cache_spans` in Django integration automatically when Spotlight is enabled and `DEBUG` is set in Django settings.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (da0b086) to head (c8e104b).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3791      +/-   ##
==========================================
- Coverage   84.30%   84.29%   -0.02%     
==========================================
  Files         137      137              
  Lines       14561    14564       +3     
  Branches     2460     2460              
==========================================
+ Hits        12275    12276       +1     
  Misses       1528     1528              
- Partials      758      760       +2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/caching.py 97.87% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

@BYK BYK enabled auto-merge (squash) November 15, 2024 21:54
@BYK BYK merged commit 955108e into master Nov 19, 2024
136 checks passed
@BYK BYK deleted the byk/feat/spotlight-cache-spans branch November 19, 2024 08:55
BYK added a commit that referenced this pull request Jan 24, 2025
This reverts commit 955108e (#3791) and simply enables `cache_spans` by default..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants