-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scope client reference on copy/fork #3849
Conversation
❌ 357 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 2 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is related code that has to be changed as well. (see other comment)
@@ -23,6 +23,7 @@ | |||
use_scope, | |||
use_isolation_scope, | |||
) | |||
from tests.conftest import ApproxDict | |||
|
|||
|
|||
SLOTS_NOT_COPIED = {"client"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove code related to SLOTS_NOT_COPIED
closing this in favor of one against master |
No description provided.