Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting config to work with new mypy version #3894

Closed
wants to merge 1 commit into from

Conversation

antonpirker
Copy link
Member

Mypy released a new version that does not allow type hints in enums anymore.

It also made some type ignoring obsolete.

Copy link

codecov bot commented Dec 23, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
13842 2 13840 4139
View the top 2 failed tests by shortest run time
tests.integrations.launchdarkly.test_launchdarkly test_launchdarkly_integration_threaded
Stack Traces | 0.107s run time
.../integrations/launchdarkly/test_launchdarkly.py:90: in test_launchdarkly_integration_threaded
    assert len(events) == 3
E   AssertionError: assert 4 == 3
E    +  where 4 = len([{'breadcrumbs': {'values': []}, 'contexts': {'flags': {'values': [{'flag': 'hello', 'result': True}, {'flag': 'world', 'result': False}]}, 'runtime': {'build': '3.12.8 (main, Dec  4 2024, 06:20:10) [GCC 9.4.0]', 'name': 'CPython', 'version': '3.12.8'}, 'trace': {'parent_span_id': None, 'span_id': 'bfeb32cebf17062d', 'trace_id': 'e5e92c72d25944ada1d7ab5467c0bc0f'}}, 'environment': 'production', 'event_id': '7d3692554a5c4102815932bd55253d6a', ...}, {'breadcrumbs': {'values': []}, 'contexts': {'flags': {'values': [{'flag': 'hello', 'result': True}, {'flag': 'other', 'result': False}]}, 'runtime': {'build': '3.12.8 (main, Dec  4 2024, 06:20:10) [GCC 9.4.0]', 'name': 'CPython', 'version': '3.12.8'}, 'trace': {'parent_span_id': None, 'span_id': 'bfeb32cebf17062d', 'trace_id': 'e5e92c72d25944ada1d7ab5467c0bc0f'}}, 'environment': 'production', 'event_id': 'c383cc3d49764b6995ec7263c28ba4ff', ...}, {'breadcrumbs': {'values': []}, 'contexts': {'runtime': {'build': '3.12.8 (main, Dec  4 2024, 06:20:10) [GCC 9.4.0]', 'name': 'CPython', 'version': '3.12.8'}, 'trace': {'parent_span_id': None, 'span_id': '9f1eb93800fadb5b', 'trace_id': '524a628fcb8e4d19bd0a00460bb0b0ca'}}, 'environment': 'production', 'event_id': '962e5d34f8124a908c49624a9e1bc113', ...}, {'breadcrumbs': {'values': []}, 'contexts': {'flags': {'values': [{'flag': 'hello', 'result': True}]}, 'runtime': {'build': '3.12.8 (main, Dec  4 2024, 06:20:10) [GCC 9.4.0]', 'name': 'CPython', 'version': '3.12.8'}, 'trace': {'parent_span_id': None, 'span_id': 'bfeb32cebf17062d', 'trace_id': 'e5e92c72d25944ada1d7ab5467c0bc0f'}}, 'environment': 'production', 'event_id': 'b02221d92ee445d8bba8c6a1706081ac', ...}])
tests.test_transport test_transport_works[threads-False-br-0-True-close-True]
Stack Traces | 0.673s run time
tests/test_transport.py:186: in test_transport_works
    assert not err and not out
E   assert (not '--- Logging error ---\nTraceback (most recent call last):\n  File ".../hostedtoolcache/Python/3.6.15.../x64/lib/python3...lhandlers\n    return old_callhandlers(self, record)\nMessage: \'background worker got kill request\'\nArguments: ()\n')

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@antonpirker antonpirker enabled auto-merge (squash) December 23, 2024 08:40
@antonpirker
Copy link
Member Author

This has been smuggled in in this PR: #3892 (because it is the holiday season and most people are not in front of a keyboard right now.)

auto-merge was automatically disabled December 23, 2024 08:45

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant