fix(flags): use feature_enabled field of unleash variants #3914
+33
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic error in #3888
After rereading https://docs.getunleash.io/reference/strategy-variants and testing w/ a local Unleash instance, I found we need to use a different variant field,
feature_enabled
.enabled
refers to whether the variant itself is enabled, but a feature/"toggle" can be enabled with no variants. In this case, a disabled variant is returned (seeno_variant_payload
in tests).