Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich authored Sep 6, 2024
1 parent 97f0c28 commit 03b8acc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/js/tools/metroconfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function withSentryConfig(
if (annotateReactComponents) {
newConfig = withSentryBabelTransformer(newConfig);
}
if (includeWebReplay !== true) {
if (options.includeWebReplay === false) {

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / metrics (new, android)

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 legacy hermes ios production dynamic

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 new hermes ios production static

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 legacy hermes android production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 legacy hermes ios production static

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 new hermes ios production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.73.9 new hermes android production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.65.3 legacy jsc android production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.65.3 legacy hermes android production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy macos dev no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy ios production no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy ios dev dynamic-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy macos production no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy ios dev no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / metrics (legacy, android)

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy android production no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy android dev no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build new android dev no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build new android production no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build new ios dev no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build new ios production no-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build legacy ios production dynamic-frameworks

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / Build RN 0.65.3 legacy jsc ios production no

Cannot find name 'options'.

Check failure on line 54 in src/js/tools/metroconfig.ts

View workflow job for this annotation

GitHub Actions / metrics (new, ios)

Cannot find name 'options'.
newConfig = withSentryResolver(newConfig, includeWebReplay);
}

Expand Down Expand Up @@ -195,7 +195,7 @@ export function withSentryResolver(config: MetroConfig, includeWebReplay: boolea
if (context.resolveRequest === sentryResolverRequest) {
// eslint-disable-next-line no-console
console.error(
`Error: [@sentry/react-native/metro] Cannot desolve the defaultResolver on Metro older than 0.68.
`Error: [@sentry/react-native/metro] Can not resolve the defaultResolver on Metro older than 0.68.
Please follow one of the following options:
- Include your resolverRequest on your metroconfig.
- Update your Metro version to 0.68 or higher.
Expand Down

0 comments on commit 03b8acc

Please sign in to comment.