Skip to content

Commit

Permalink
fix(xcode): Collect modules path from shell (#3451)
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich authored Dec 5, 2023
1 parent 4b629ec commit 459c176
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- This fix requires a rebuild of the native app
- Symbolicate message and non-Error stacktraces locally in debug mode ([#3420](https://github.com/getsentry/sentry-react-native/pull/3420))
- Remove Sentry SDK frames from rejected promise SyntheticError stack ([#3423](https://github.com/getsentry/sentry-react-native/pull/3423))
- Fix path from Xcode scripts to Collect Modules ([#3451](https://github.com/getsentry/sentry-react-native/pull/3451))

### Dependencies

Expand Down
2 changes: 1 addition & 1 deletion scripts/collect-modules.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if [[ -n "$NODE_BINARY" ]]; then
fi

thisFilePath=$(dirname $0)
collectModulesScript="$thisFilePath/../../dist/js/tools/collectModules.js"
collectModulesScript="$thisFilePath/../dist/js/tools/collectModules.js"

destination="$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH"
modulesOutput="$destination/modules.json"
Expand Down
2 changes: 1 addition & 1 deletion scripts/sentry-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ else
/bin/sh -c "$REACT_NATIVE_XCODE"
fi

[ -z "$SENTRY_COLLECT_MODULES" ] && SENTRY_COLLECT_MODULES="../../scripts/collect-modules.sh"
[ -z "$SENTRY_COLLECT_MODULES" ] && SENTRY_COLLECT_MODULES="../node_modules/@sentry/react-native/scripts/collect-modules.sh"

if [ -f "$SENTRY_COLLECT_MODULES" ]; then
/bin/sh "$SENTRY_COLLECT_MODULES"
Expand Down

0 comments on commit 459c176

Please sign in to comment.