Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): 🌟 add support for React Native 0.73 #3133

Merged
merged 8 commits into from
Jun 26, 2023
Merged

feat(android): 🌟 add support for React Native 0.73 #3133

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a8bce7
feat(android): 🌟 add support for React Native 0.73
peterlazar1993 Jun 19, 2023
314ec58
Apply suggestions from code review
krystofwoldrich Jun 20, 2023
068b3d1
Update CHANGELOG.md
krystofwoldrich Jun 20, 2023
1566edf
Fix RN Cli namespace matching
krystofwoldrich Jun 20, 2023
e59d66b
Update android/build.gradle
krystofwoldrich Jun 20, 2023
0624f94
Ensure compatibility with older versions keep package in android mani…
krystofwoldrich Jun 20, 2023
267921c
Update build.gradle
krystofwoldrich Jun 22, 2023
d1b9f08
Merge branch 'main' into main
krystofwoldrich Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ if (isNewArchitectureEnabled()) {
}

android {
// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace 'io.sentry.react'
krystofwoldrich marked this conversation as resolved.
Show resolved Hide resolved
}
compileSdkVersion safeExtGet('compileSdkVersion', 31)

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.sentry.react">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
krystofwoldrich marked this conversation as resolved.
Show resolved Hide resolved
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<application>
Expand Down