Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sample): Disable SAGP autoInstallation #3136

Merged
merged 2 commits into from
Jul 13, 2023
Merged

chore(sample): Disable SAGP autoInstallation #3136

merged 2 commits into from
Jul 13, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 20, 2023 •
edited
Loading

The Sentry Android Gradle Plugin auto installation can potentially break the RN SDK by installing a newer version of the Android SDK which can be potentially incompatible. RN SDK shipped with a comparable version of sentry-android.

#skip-changelog

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 342.27 ms 389.64 ms 47.37 ms
Size 17.73 MiB 19.80 MiB 2.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b1e8712 462.11 ms 465.71 ms 3.60 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms

App size

Revision Plain With Sentry Diff
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1252.16 ms 1273.74 ms 21.58 ms
Size 2.36 MiB 2.85 MiB 499.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB

marandaneto
marandaneto reviewed Jun 20, 2023
View reviewed changes
sample-new-architecture/android/app/build.gradle Outdated
Comment on lines 20 to 22
// Enable auto-installation of Sentry components (sentry-android SDK and okhttp, timber and fragment integrations).
// Default is enabled.
// Only available v3.1.0 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment that the RN SDK already ships the Android SDK

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 258.81 ms 321.76 ms 62.95 ms
Size 7.15 MiB 8.08 MiB 959.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@krystofwoldrich krystofwoldrich marked this pull request as ready for review July 12, 2023 14:16
lucas-zimerman
lucas-zimerman approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the PR!

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1207.21 ms 1220.34 ms 13.13 ms
Size 2.92 MiB 3.41 MiB 503.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB

@krystofwoldrich krystofwoldrich merged commit 3853f43 into main Jul 13, 2023
@krystofwoldrich krystofwoldrich deleted the kw-sagp-sample-disable-auto-installation branch July 13, 2023 07:56
@krystofwoldrich krystofwoldrich mentioned this pull request Jul 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto left review comments

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @marandaneto @lucas-zimerman