Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react typings fix deprecated JSX global imports #3173

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • [] Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

We should not switch to the new scoped React.JSX yet, because it could break projects with older typings.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1264.30 ms 1279.72 ms 15.42 ms
Size 2.36 MiB 2.85 MiB 499.84 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 263.88 ms 307.40 ms 43.53 ms
Size 7.15 MiB 8.08 MiB 955.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB

@krystofwoldrich krystofwoldrich merged commit 248ea69 into main Jul 17, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-react-jsx-global-types branch July 17, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants