Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.9.1 #3188

Merged
merged 1 commit into from
Jul 17, 2023
Merged

chore(deps): update Cocoa SDK to v8.9.1 #3188

merged 1 commit into from
Jul 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 14, 2023 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.8.0 to 8.9.1.

Auto-generated by a dependency updater.

Changelog

8.9.1

Fixes

  • Fix potential unbounded memory growth when starting profiled transactions from non-main contexts (#3135)

8.9.0

Features

  • Symbolicate locally only when debug is enabled (#3079)
  • Sanitize HTTP info from breadcrumbs, spans and events (#3094)

Breaking change

  • Renamed enableTimeToFullDisplay to enableTimeToFullDisplayTracing (#3106)
    • This is an experimental feature and may change at any time without a major revision.

8.9.0-beta.1

Features

  • Symbolicate locally only when debug is enabled (#3079)
  • Sanitize HTTP info from breadcrumbs, spans and events (#3094)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 14, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 236.04 ms 334.50 ms 98.46 ms
Size 17.73 MiB 19.82 MiB 2.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
9af52f2 364.43 ms 379.30 ms 14.87 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms
8ba8074 326.52 ms 339.04 ms 12.52 ms
955f10d 351.88 ms 364.50 ms 12.62 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9af52f2 17.73 MiB 19.80 MiB 2.07 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB
8ba8074 17.73 MiB 19.81 MiB 2.08 MiB
955f10d 17.73 MiB 19.80 MiB 2.07 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 14, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1262.36 ms 1270.74 ms 8.38 ms
Size 2.36 MiB 2.86 MiB 508.78 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
955f10d+dirty 1270.66 ms 1278.60 ms 7.94 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms
8ba8074+dirty 1222.44 ms 1243.82 ms 21.38 ms
9af52f2+dirty 1273.67 ms 1286.72 ms 13.05 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
955f10d+dirty 2.36 MiB 2.85 MiB 496.13 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB
8ba8074+dirty 2.36 MiB 2.86 MiB 507.04 KiB
9af52f2+dirty 2.36 MiB 2.85 MiB 497.02 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 14, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1256.24 ms 1270.14 ms 13.90 ms
Size 2.92 MiB 3.42 MiB 511.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms

App size

Revision Plain With Sentry Diff
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1263.68 ms 1273.90 ms 10.22 ms
955f10d+dirty 1293.94 ms 1298.86 ms 4.92 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms
8ba8074+dirty 1284.04 ms 1309.42 ms 25.38 ms
9af52f2+dirty 1256.52 ms 1258.94 ms 2.42 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.92 MiB 3.38 MiB 474.71 KiB
955f10d+dirty 2.92 MiB 3.41 MiB 499.55 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB
8ba8074+dirty 2.92 MiB 3.42 MiB 510.57 KiB
9af52f2+dirty 2.92 MiB 3.41 MiB 500.73 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 14, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 285.85 ms 353.90 ms 68.05 ms
Size 7.15 MiB 8.08 MiB 961.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
955f10d+dirty 306.27 ms 385.83 ms 79.57 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms
8ba8074+dirty 264.25 ms 315.40 ms 51.15 ms
9af52f2+dirty 272.87 ms 305.61 ms 32.74 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
955f10d+dirty 7.15 MiB 8.07 MiB 946.13 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB
8ba8074+dirty 7.15 MiB 8.08 MiB 959.34 KiB
9af52f2+dirty 7.15 MiB 8.07 MiB 947.16 KiB

@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.9.0 chore(deps): update Cocoa SDK to v8.9.1 Jul 15, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 4 times, most recently from 60b80ec to 34baa0a Compare July 17, 2023 09:21
krystofwoldrich
krystofwoldrich approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit a4076f9 into main Jul 17, 2023
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch July 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow