Use direct reference to node #3493

lucas-zimerman · 2024-01-04T18:45:58Z

Fixes #3472

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2024-01-04T19:06:04Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	400.28 ms	406.76 ms	6.48 ms
Size	17.73 MiB	19.85 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`2534337`	394.15 ms	415.12 ms	20.97 ms
`e2b64fe`	316.88 ms	330.23 ms	13.35 ms
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`457e29f`	398.10 ms	421.39 ms	23.29 ms
`22e31b6`	396.48 ms	419.64 ms	23.16 ms

App size

Revision	Plain	With Sentry	Diff
`2534337`	17.73 MiB	19.84 MiB	2.11 MiB
`e2b64fe`	17.73 MiB	19.80 MiB	2.07 MiB
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`457e29f`	17.73 MiB	19.84 MiB	2.10 MiB
`22e31b6`	17.73 MiB	19.84 MiB	2.10 MiB

github-actions · 2024-01-04T19:40:51Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	340.73 ms	374.90 ms	34.16 ms
Size	7.15 MiB	8.11 MiB	990.04 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms
`1d86dd6`+dirty	335.76 ms	371.22 ms	35.46 ms
`b1e8712`+dirty	322.55 ms	331.84 ms	9.29 ms
`9433f35`+dirty	265.50 ms	336.08 ms	70.58 ms
`3ffcddd`+dirty	244.82 ms	295.47 ms	50.65 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`575f9da`+dirty	337.15 ms	370.47 ms	33.32 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms

App size

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB
`1d86dd6`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`b1e8712`+dirty	7.15 MiB	8.04 MiB	912.27 KiB
`9433f35`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`3ffcddd`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`575f9da`+dirty	7.15 MiB	8.10 MiB	979.68 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB

… into fix/custom-node

scripts/sentry-xcode.sh

scripts/sentry-xcode-debug-files.sh

Co-authored-by: Kryštof Woldřich <[email protected]>

github-actions · 2024-01-11T17:23:11Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1208.35 ms	1209.88 ms	1.53 ms
Size	2.36 MiB	2.88 MiB	525.40 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`1d86dd6`+dirty	1249.71 ms	1279.16 ms	29.45 ms
`d361d38`+dirty	1246.04 ms	1267.12 ms	21.08 ms
`12427f4`+dirty	1267.15 ms	1271.30 ms	4.15 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`22e31b6`+dirty	1253.62 ms	1265.96 ms	12.34 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`1d86dd6`+dirty	2.36 MiB	2.89 MiB	535.43 KiB
`d361d38`+dirty	2.36 MiB	2.85 MiB	499.84 KiB
`12427f4`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`22e31b6`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB

github-actions · 2024-01-11T17:29:00Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1259.21 ms	1261.51 ms	2.30 ms
Size	2.92 MiB	3.44 MiB	530.86 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`d361d38`+dirty	1272.96 ms	1291.70 ms	18.74 ms
`12427f4`+dirty	1224.90 ms	1231.40 ms	6.50 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`22e31b6`+dirty	1276.55 ms	1278.12 ms	1.57 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`d361d38`+dirty	2.92 MiB	3.41 MiB	503.57 KiB
`12427f4`+dirty	2.92 MiB	3.44 MiB	533.29 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`22e31b6`+dirty	2.92 MiB	3.43 MiB	524.74 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB

CHANGELOG.md

scripts/sentry-xcode.sh

krystofwoldrich · 2024-01-22T16:03:58Z

Looks good 🚀, thank you.

use direct reference to node

e2bd86f

Yuniac mentioned this pull request Jan 10, 2024

Xcode scripts should not use node from path #3472

Closed

11 tasks

lucas-zimerman added 2 commits January 11, 2024 11:02

Merge branch 'main' of https://github.com/getsentry/sentry-react-native…

1faf7ce

… into fix/custom-node

changelog

da606a7

lucas-zimerman marked this pull request as ready for review January 11, 2024 14:03

lucas-zimerman requested a review from krystofwoldrich as a code owner January 11, 2024 14:03

krystofwoldrich reviewed Jan 11, 2024

View reviewed changes

scripts/sentry-xcode.sh Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jan 11, 2024

View reviewed changes

scripts/sentry-xcode.sh Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jan 11, 2024

View reviewed changes

scripts/sentry-xcode-debug-files.sh Outdated Show resolved Hide resolved

Update scripts/sentry-xcode.sh

bc44fa0

Co-authored-by: Kryštof Woldřich <[email protected]>

Merge branch 'main' into fix/custom-node

f4c68f2

lucas-zimerman commented Jan 19, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman commented Jan 19, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman added 3 commits January 19, 2024 09:48

Update CHANGELOG.md

4606c43

use local node

1a71943

use local node

d08b162

krystofwoldrich reviewed Jan 19, 2024

View reviewed changes

scripts/sentry-xcode.sh Outdated Show resolved Hide resolved

krystofwoldrich and others added 5 commits January 19, 2024 17:28

Update scripts/sentry-xcode.sh

4332f31

Update CHANGELOG.md

e1789d4

Merge branch 'main' into fix/custom-node

352d535

double check node_binary exist

2cc3a76

use old method for loading node

e65d1fe

krystofwoldrich approved these changes Jan 22, 2024

View reviewed changes

krystofwoldrich merged commit 46f3245 into main Jan 22, 2024
48 of 50 checks passed

krystofwoldrich deleted the fix/custom-node branch January 22, 2024 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use direct reference to node #3493

Use direct reference to node #3493

lucas-zimerman commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 4, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 11, 2024

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 11, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Jan 22, 2024

Use direct reference to node #3493

Use direct reference to node #3493

Conversation

lucas-zimerman commented Jan 4, 2024 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jan 4, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 4, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 11, 2024

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 11, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Jan 22, 2024

lucas-zimerman commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 11, 2024 •

edited

Loading