Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Remove JS V8 dropped packages from the update CI #3894

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 17, 2024

JS V8 removed some packages used in RN V5.

The use of these packages is removed in RN V6.

We have to update the CI on main, otherwise the updater job keeps failing.

#skip-changelog

Result PR after the change #3895

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 333.70 ms 371.19 ms 37.49 ms
Size 7.15 MiB 8.21 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
5571a20+dirty 359.52 ms 389.80 ms 30.28 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
2534337+dirty 597.14 ms 665.04 ms 67.90 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
5571a20+dirty 7.15 MiB 8.20 MiB 1.05 MiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit d6c1900 into main Jun 17, 2024
56 of 60 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-fix-js-update branch June 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants