Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix OOM builds #4032

Merged
merged 3 commits into from
Aug 19, 2024
Merged

CI: fix OOM builds #4032

merged 3 commits into from
Aug 19, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Aug 16, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 484.85 ms 543.42 ms 58.57 ms
Size 17.73 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27ef4ee 317.40 ms 321.70 ms 4.30 ms
6e8584e 447.10 ms 474.71 ms 27.61 ms
148f924 492.65 ms 500.28 ms 7.63 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms

App size

Revision Plain With Sentry Diff
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB

Copy link
Contributor

github-actions bot commented Aug 16, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.23 ms 1242.10 ms 5.88 ms
Size 2.92 MiB 3.64 MiB 738.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Copy link
Contributor

github-actions bot commented Aug 16, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.98 ms 1220.92 ms 1.94 ms
Size 2.36 MiB 3.08 MiB 731.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
c398f67+dirty 1219.67 ms 1225.66 ms 5.99 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
c398f67+dirty 2.36 MiB 3.04 MiB 696.27 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB

@vaind vaind changed the title fix: oom builds CI: fix OOM builds Aug 16, 2024
@vaind vaind marked this pull request as ready for review August 18, 2024 10:43
@krystofwoldrich
Copy link
Member

Looks good!

Should we also up the JVM memory for the perf build and the sample app, currently they are on the default 2 GB.

@vaind vaind merged commit 0abe24e into main Aug 19, 2024
55 of 57 checks passed
@vaind vaind deleted the ci/fix-oom-builds branch August 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants