Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove deprecated Spotlight options #4086

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

### Changes

- Remove deprecated `enableSpotlight` and `spotlightSidecarUrl` ([#4086](https://github.com/getsentry/sentry-react-native/pull/4086))
- `tracePropagationTargets` defaults to all targets on mobile and same origin on the web ([#4083](https://github.com/getsentry/sentry-react-native/pull/4083))
- Move `_experiments.profilesSampleRate` to `profilesSampleRate` root options object [#3851](https://github.com/getsentry/sentry-react-native/pull/3851))
- Add Android Logger when new frame event is not emitted ([#4081](https://github.com/getsentry/sentry-react-native/pull/4081))
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/js/integrations/default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ export function getDefaultIntegrations(options: ReactNativeClientOptions): Integ
integrations.push(expoContextIntegration());
}

if (options.spotlight || options.enableSpotlight) {
const sidecarUrl = (typeof options.spotlight === 'string' && options.spotlight) || options.spotlightSidecarUrl;
if (options.spotlight) {
const sidecarUrl = typeof options.spotlight === 'string' ? options.spotlight : undefined;
integrations.push(spotlightIntegration({ sidecarUrl }));
}

Expand Down
25 changes: 0 additions & 25 deletions packages/core/src/js/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,31 +164,6 @@ export interface BaseReactNativeOptions {
*/
enableCaptureFailedRequests?: boolean;

/**
* This option will enable forwarding captured Sentry events to Spotlight.
*
* More details: https://spotlightjs.com/
*
* IMPORTANT: Only set this option to `true` while developing, not in production!
*
* @deprecated Use `spotlight` instead.
*/
enableSpotlight?: boolean;

/**
* This option changes the default Spotlight Sidecar URL.
*
* By default, the SDK expects the Sidecar to be running
* on the same host as React Native Metro Dev Server.
*
* More details: https://spotlightjs.com/
*
* @default "http://localhost:8969/stream"
*
* @deprecated Use `spotlight` instead.
*/
spotlightSidecarUrl?: string;

/**
* If you use Spotlight by Sentry during development, use
* this option to forward captured Sentry events to Spotlight.
Expand Down
8 changes: 0 additions & 8 deletions packages/core/test/sdk.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -404,14 +404,6 @@ describe('Tests the SDK functionality', () => {
expectNotIntegration('Spotlight');
});

it('adds spotlight integration with enableSpotlight', () => {
init({
enableSpotlight: true,
});

expectIntegration('Spotlight');
});

it('no app start integration by default', () => {
init({});

Expand Down
Loading