Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(xcode): Use foreground upload by default #4090

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Enhancement

📜 Description

Change default to blocking foreground upload of debug files and source maps.

This helps with bug reports, as we can see the whole log by default.

Also this change mitigates issue with sentry-cli and curl library which in newer versions fail in background.

Related issues

💚 How did you test it?

ci, sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.19 ms 434.19 ms 33.00 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented Sep 13, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.57 ms 1232.77 ms -1.80 ms
Size 2.36 MiB 3.08 MiB 733.36 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB

Copy link
Contributor

github-actions bot commented Sep 13, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.80 ms 1246.31 ms -1.49 ms
Size 2.92 MiB 3.64 MiB 739.24 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 442.13 ms 448.06 ms 5.93 ms
Size 17.74 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902 484.04 ms 487.57 ms 3.53 ms

App size

Revision Plain With Sentry Diff
f77a902 17.74 MiB 20.06 MiB 2.33 MiB

@krystofwoldrich krystofwoldrich merged commit d296b5b into v6 Oct 1, 2024
56 of 57 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/foreground-xcode-upload-by-default branch October 1, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants