Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Android SDK to v7.17.0 #4266

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore(deps): update Android SDK to v7.17.0 #4266

merged 1 commit into from
Nov 14, 2024
+4 −4

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2024 •
edited by lucas-zimerman
Loading

Bumps scripts/update-android.sh from 7.16.0 to 7.17.0.

Auto-generated by a dependency updater.

Changelog

7.17.0

Features

  • Add meta option to set the maximum amount of breadcrumbs to be logged. (#3836)
  • Use a separate Random instance per thread to improve SDK performance (#3835)

Fixes

  • Using MaxBreadcrumb with value 0 no longer crashes. (#3836)
  • Accept manifest integer values when requiring floating values (#3823)
  • Fix standalone tomcat jndi issue (#3873)
    • Using Sentry Spring Boot on a standalone tomcat caused the following error:
      • Failed to bind properties under 'sentry.parsed-dsn' to io.sentry.Dsn

Close #3634

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 12, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 451.26 ms 454.69 ms 3.43 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
52c0562 453.04 ms 434.71 ms -18.33 ms
63ed251 457.74 ms 441.54 ms -16.20 ms
baa882f 354.93 ms 356.18 ms 1.25 ms
c398f67 449.64 ms 461.38 ms 11.74 ms
728164b 414.34 ms 449.22 ms 34.88 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
148f924 492.65 ms 500.28 ms 7.63 ms
a5d86e1 465.06 ms 457.83 ms -7.23 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
8c88ac7 411.15 ms 400.54 ms -10.60 ms

App size

Revision Plain With Sentry Diff
52c0562 17.73 MiB 20.11 MiB 2.38 MiB
63ed251 17.74 MiB 20.08 MiB 2.34 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB
c398f67 17.73 MiB 19.94 MiB 2.21 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
a5d86e1 17.74 MiB 20.08 MiB 2.34 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8c88ac7 17.74 MiB 20.08 MiB 2.34 MiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
be73e1a 418.89 ms 410.35 ms -8.54 ms
d5edb06 485.92 ms 502.18 ms 16.27 ms

App size

Revision Plain With Sentry Diff
be73e1a 17.74 MiB 20.08 MiB 2.34 MiB
d5edb06 17.73 MiB 20.11 MiB 2.38 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 12, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.20 ms 1222.30 ms -7.90 ms
Size 2.36 MiB 3.10 MiB 752.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e540498+dirty 1220.61 ms 1212.93 ms -7.68 ms
b95b8af+dirty 1221.39 ms 1228.52 ms 7.13 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
eb1e19f+dirty 1209.56 ms 1214.94 ms 5.38 ms
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
8c88ac7+dirty 1205.13 ms 1218.87 ms 13.74 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
d2c32bb+dirty 1223.69 ms 1229.49 ms 5.80 ms

App size

Revision Plain With Sentry Diff
e540498+dirty 2.36 MiB 3.14 MiB 793.34 KiB
b95b8af+dirty 2.36 MiB 3.14 MiB 793.32 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
eb1e19f+dirty 2.36 MiB 3.08 MiB 737.21 KiB
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
8c88ac7+dirty 2.36 MiB 3.10 MiB 752.63 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
d2c32bb+dirty 2.36 MiB 3.08 MiB 737.22 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
be73e1a+dirty 1213.57 ms 1224.11 ms 10.54 ms
d5edb06+dirty 1236.40 ms 1245.30 ms 8.90 ms

App size

Revision Plain With Sentry Diff
be73e1a+dirty 2.36 MiB 3.10 MiB 752.64 KiB
d5edb06+dirty 2.36 MiB 3.14 MiB 793.32 KiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 12, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.10 ms 1219.23 ms -5.88 ms
Size 2.92 MiB 3.66 MiB 756.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
a5d86e1+dirty 1230.35 ms 1222.47 ms -7.88 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
d2c32bb+dirty 1244.00 ms 1245.77 ms 1.77 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
52c0562+dirty 1233.94 ms 1226.29 ms -7.65 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms

App size

Revision Plain With Sentry Diff
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
a5d86e1+dirty 2.92 MiB 3.66 MiB 757.10 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
d2c32bb+dirty 2.92 MiB 3.64 MiB 742.84 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
52c0562+dirty 2.92 MiB 3.69 MiB 794.15 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
be73e1a+dirty 1246.69 ms 1243.78 ms -2.92 ms
d5edb06+dirty 1234.31 ms 1237.86 ms 3.54 ms

App size

Revision Plain With Sentry Diff
be73e1a+dirty 2.92 MiB 3.66 MiB 757.11 KiB
d5edb06+dirty 2.92 MiB 3.69 MiB 794.20 KiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 13, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.55 ms 442.16 ms 47.61 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9cab16b+dirty 370.82 ms 416.37 ms 45.55 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
0d3e677+dirty 384.24 ms 431.45 ms 47.21 ms
e73d82f+dirty 377.67 ms 407.06 ms 29.39 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
2534337+dirty 597.14 ms 665.04 ms 67.90 ms
c398f67+dirty 315.08 ms 345.60 ms 30.52 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms

App size

Revision Plain With Sentry Diff
9cab16b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
0d3e677+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e73d82f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB
c398f67+dirty 7.15 MiB 8.21 MiB 1.07 MiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
d5edb06+dirty 378.54 ms 414.26 ms 35.72 ms
be73e1a+dirty 397.04 ms 452.15 ms 55.11 ms

App size

Revision Plain With Sentry Diff
d5edb06+dirty 7.15 MiB 8.39 MiB 1.24 MiB
be73e1a+dirty 7.15 MiB 8.35 MiB 1.20 MiB

antonis
antonis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucas-zimerman
lucas-zimerman approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) November 14, 2024 09:56
@lucas-zimerman lucas-zimerman enabled auto-merge (squash) November 14, 2024 09:57
@lucas-zimerman lucas-zimerman merged commit 8de2810 into main Nov 14, 2024
55 of 62 checks passed
@lucas-zimerman lucas-zimerman deleted the deps/scripts/update-android.sh branch November 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@antonis antonis antonis approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxBreadcrumbSize to 0 crashes Android on Start
3 participants
@antonis @lucas-zimerman @web-flow