feat(replay): Add Mask and Unmask Wrappers for react-native-web #4272
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
|
krystofwoldrich
force-pushed
the
kw/feat/add-custom-mask-for-web
branch
from
02648ca
to
1ebf033
Compare
mydea
reviewed
Nov 14, 2024
Comment on lines
+6
to
+7
| mask: ['div.sentry-react-native-mask', ...(options.mask || [])], | ||
| unmask: ['div.sentry-react-native-unmask:not(div.sentry-react-native-mask *) > *', ...(options.unmask || [])], |
There was a problem hiding this comment.
super-tiny-l, but I'd say the div. part is not really necessary here? 🤔 But just a thought, feel free to disregard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR add the
MaskandUnmaskwrapper functions forreact-native-web.Requires fix(replay):
browserReplayIntegrationshould not be included by default #4270Android implementation feat(replay): Add Mask and Unmask Android implementation #4265
iOS implementation feat(replay): Add SentryMask and SentryUnmask native components #4224
💚 How did you test it?
expo sample app
📝 Checklist
sendDefaultPIIis enabled